Skip tests in code rather than in test plan for Networking (#15725)

Author: mokagio

Networking/NetworkingTests/Mapper/InAppPurchaseOrderResultMapperTests.swift

@@ -3,6 +3,8 @@ import XCTest
 
 final class InAppPurchasesOrderResultMapperTests: XCTestCase {
     func test_iap_order_creation_is_decoded_from_json_response() throws {
+        try XCTSkipIf(true)
+
         // Given
         let jsonData = try XCTUnwrap(Loader.contentsOf("iap-order-create"))
         let expectedOrderId = 12345

Networking/NetworkingTests/Mapper/InAppPurchasesProductsMapperTests.swift

@@ -3,6 +3,8 @@ import XCTest
 
 final class InAppPurchasesProductsMapperTests: XCTestCase {
     func test_iap_products_list_is_decoded_from_json_response() throws {
+        try XCTSkipIf(true)
+
         // Given
         let jsonData = try XCTUnwrap(Loader.contentsOf("iap-products"))
         let expectedProductIdentifiers = [

Networking/NetworkingTests/Mapper/InAppPurchasesTransactionMapperTests.swift

@@ -3,6 +3,8 @@ import XCTest
 
 final class InAppPurchasesTransactionMapperTests: XCTestCase {
     func test_iap_handled_transaction_is_decoded_from_json_response() throws {
+        try XCTSkipIf(true)
+
         // Given
         let jsonData = try XCTUnwrap(Loader.contentsOf("iap-transaction-handled"))
         let expectedSiteID = Int64(1234)
@@ -15,6 +17,8 @@ final class InAppPurchasesTransactionMapperTests: XCTestCase {
     }
 
     func test_iap_unhandled_transaction_is_decoded_from_json_response() throws {
+        try XCTSkipIf(true)
+
         // Given
         let jsonData = try XCTUnwrap(Loader.contentsOf("iap-transaction-not-handled"))
         let expectedErrorMessage = "Transaction not found."

Networking/NetworkingTests/Remote/InAppPurchasesRemoteTests.swift

@@ -28,6 +28,8 @@ class InAppPurchasesRemoteTests: XCTestCase {
     /// Verifies that 'moderateComment' as spam properly parses the successful response
     ///
     func test_load_products_returns_list_of_products() throws {
+        try XCTSkipIf(true)
+
         // Given
         let remote = InAppPurchasesRemote(network: network)
 
@@ -48,6 +50,8 @@ class InAppPurchasesRemoteTests: XCTestCase {
     }
 
     func test_purchase_product_returns_created_order() throws {
+        try XCTSkipIf(true)
+
         // Given
         let remote = InAppPurchasesRemote(network: network)
 
@@ -75,6 +79,8 @@ class InAppPurchasesRemoteTests: XCTestCase {
     }
 
     func test_retrieveHandledTransactionSiteID_when_success_to_retrieve_response_and_transaction_is_handled_then_returns_siteID() throws {
+        try XCTSkipIf(true)
+
         // Given
         let remote = InAppPurchasesRemote(network: network)
         let transactionID: UInt64 = 1234
@@ -118,6 +124,8 @@ class InAppPurchasesRemoteTests: XCTestCase {
     }
 
     func test_retrieveHandledTransactionSiteID_when_fails_to_retrieve_response_then_returns_network_error() throws {
+        try XCTSkipIf(true)
+
         // Given
         let remote = InAppPurchasesRemote(network: network)
         let transactionID: UInt64 = 1234

Networking/NetworkingTests/Remote/WCPayRemoteTests.swift

@@ -111,6 +111,8 @@ final class WCPayRemoteTests: XCTestCase {
 
         XCTAssertTrue(result.isSuccess)
         let account = try result.get()
+
+        XCTExpectFailure("isCardPresentEligible has been hardcoded to true. See https://github.com/woocommerce/woocommerce-ios/pull/5030")
         XCTAssertEqual(account.isCardPresentEligible, false)
     }
 
@@ -130,6 +132,8 @@ final class WCPayRemoteTests: XCTestCase {
 
         XCTAssertTrue(result.isSuccess)
         let account = try result.get()
+
+        XCTExpectFailure("isCardPresentEligible has been hardcoded to true. See https://github.com/woocommerce/woocommerce-ios/pull/5030")
         XCTAssertEqual(account.isCardPresentEligible, false)
     }
 

WooCommerce/WooCommerceTests/UnitTests.xctestplan

@@ -88,22 +88,6 @@
       }
     },
     {
-      "skippedTests" : [
-        "InAppPurchasesOrderResultMapperTests",
-        "InAppPurchasesOrderResultMapperTests\/test_iap_order_creation_is_decoded_from_json_response()",
-        "InAppPurchasesProductsMapperTests",
-        "InAppPurchasesRemoteTests",
-        "InAppPurchasesRemoteTests\/test_load_products_returns_list_of_products()",
-        "InAppPurchasesRemoteTests\/test_purchase_product_returns_created_order()",
-        "InAppPurchasesRemoteTests\/test_retrieveHandledTransactionSiteID_when_fails_to_retrieve_response_then_returns_network_error()",
-        "InAppPurchasesRemoteTests\/test_retrieveHandledTransactionSiteID_when_success_to_retrieve_response_and_transaction_is_handled_then_returns_siteID()",
-        "InAppPurchasesRemoteTests\/test_retrieveHandledTransactionSiteID_when_success_to_retrieve_response_and_transaction_is_not_handled_then_returns_errorResponse()",
-        "InAppPurchasesTransactionMapperTests",
-        "InAppPurchasesTransactionMapperTests\/test_iap_handled_transaction_is_decoded_from_json_response()",
-        "InAppPurchasesTransactionMapperTests\/test_iap_unhandled_transaction_is_decoded_from_json_response()",
-        "WCPayRemoteTests\/test_loadAccount_properly_handles_implicitly_not_eligible_for_card_present_payments()",
-        "WCPayRemoteTests\/test_loadAccount_properly_handles_not_eligible_for_card_present_payments()"
-      ],
       "target" : {
         "containerPath" : "container:..\/Networking\/Networking.xcodeproj",
         "identifier" : "B557D9EB209753AA005962F4",