Fix query compatible for JSON services #3468
Draft
+26
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbera87
reviewed
Jun 27, 2025
| @Override | ||
| protected SdkFileEntry generateErrorSourceFile(ServiceModel serviceModel) throws Exception { | ||
| serviceModel.setQueryCompatibleErrorMappings(ImmutableMap.of( | ||
| "DASHBOARD_NOT_FOUND", "DashboardNotFoundError" |
There was a problem hiding this comment.
nit: perhaps using
.put("DASHBOARD_NOT_FOUND", "DashboardNotFoundError") better so that in future multiple key,value pairs can be added
There was a problem hiding this comment.
ImmutableMap.of can be used that way i.e.
ImmutableMap.of(
"key1", "value1",
"key2", "value2",
"key3", "value3",
"key4", "value4",
)
sbera87
approved these changes
Jun 27, 2025
sbiscigl
force-pushed
the
cloudwatch-query-compat
branch
from
256c048 to
432ecf3
Compare
sbiscigl
changed the title
sbiscigl
force-pushed
the
cloudwatch-query-compat
branch
from
432ecf3 to
89a2c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
GetDashboardin cloudwatch monitoring integration tests to make sure the correct error is being returned.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.