Skip to content

config: fix target override #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2021
Merged

config: fix target override #66

merged 1 commit into from
May 17, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented May 17, 2021

extra_labels_add should be applied to a target

@0xc0170
config: fix target override
031e4a4 
`extra_labels_add` should be applied to a target
@0xc0170
Copy link
Contributor Author

0xc0170 commented May 17, 2021

Mbed OS master testing failing ARMmbed/mbed-os#14661 (comment) (the latest CI run)

LDong-Arm
LDong-Arm approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.
Somehow Mbed CLI 2 (mbed-tools) did allow it without target. I'll create another PR to add testing for Mbed CLI 1.

@0xc0170 0xc0170 merged commit 17fc519 into development May 17, 2021
@LDong-Arm LDong-Arm mentioned this pull request May 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xc0170 @LDong-Arm