-
Notifications
You must be signed in to change notification settings - Fork 3k
Move mbed-stubs-drivers to the drivers directory #14786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rajkan01, thank you for your changes. |
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions. |
Move the drivers stub library into the drivers component directory. so we can avoid duplicating the mbed-os source tree in a central UNITTESTS folder.
Move the header-only mbed-headers-drivers library the unit test stubs depend on into the drivers component directory. This makes the drivers stubs more self-contained and improves the composition of the library.
Previously the drivers stub library depended on `mbed-headers`, which is a collection of all available headers in mbed-os. To make it easier to separate the library, only depend on the headers we're using.
93cf853
to
e64d1c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Fixes #14796
This PR makes the
mbed-stubs-drivers
library more self-contained by removing the dependencies on the monolithic header libraries we created to make implementing the stubs easier. We also move the files to thedrivers
directory so the stubs live with the associated component.And the
mbed-stubs-drivers
library andunit tests
should only depend on the headers it uses.Impact of changes
None
Migration actions required
None
Documentation
To be updated
Pull request type
Test results
Reviewers