M2354: inherit PSA_V8_M devices #14807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `MCU_M2354`, the use of `device_has` in `targets.json` overrides the devices present in the base target: `PSA_V8_M`. In particular, `DEVICE_TRNG` is missing in `NU_M2354` builds as `TRNG` is a member of the `PSA_V8_M` `device_has` list. As suggested by @ccli8, to ensure that `PSA_V8_M` devices are inherited by derived targets, such as `MCU_M2354`, the correct syntax to use is `device_has_add`.
ghost
mentioned this pull request
0xc0170
approved these changes
Jun 21, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
ccli8
approved these changes
Jun 22, 2021
0xc0170
added
release-type: patch
mbedmain
added
release-version: 6.13.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
For
MCU_M2354, the use ofdevice_hasintargets.jsonoverrides the devicespresent in the base target:
PSA_V8_M. In particular,DEVICE_TRNGis missingin
NU_M2354builds asTRNGis a member of thePSA_V8_Mdevice_haslist.As suggested by @ccli8, to ensure that
PSA_V8_Mdevices are inherited byderived targets, such as
MCU_M2354, the correct syntax to use isdevice_has_add.Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@MarceloSalazar
@ccli8