Skip to content

MAX32630FTHR: Port USBSerial from mbed6.x #14830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2021
Merged

MAX32630FTHR: Port USBSerial from mbed6.x #14830

merged 1 commit into from
Jul 15, 2021

Conversation

ahmetalincak
Copy link

Summary of changes

USB HW implementation added for MAX32630FTHR board.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team June 25, 2021 09:30
@ciarmcom
Copy link
Member

@ahmetalincak, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Port USBSerial from mbed6.x MAX32630FTHR: Port USBSerial from mbed6.x Jun 25, 2021
@0xc0170 0xc0170 requested a review from andypowers June 25, 2021 09:33
@mergify mergify bot added needs: CI and removed needs: review labels Jun 29, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 30, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jul 2, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2021

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 6, 2021

Internal error, I'll check and restart CI

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jul 9, 2021
@0xc0170 0xc0170 removed the stale Stale Pull Request label Jul 14, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 14, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jul 14, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

andypowers
andypowers approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 8a09a23 into ARMmbed:mbed-os-5.15 Jul 15, 2021
@mergify mergify bot removed the ready for merge label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@andypowers andypowers andypowers approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahmetalincak @ciarmcom @0xc0170 @mbed-ci @andypowers