Skip to content

Standard Pin Name: LED1 issue for targets without LED #14881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Standard Pin Name: LED1 issue for targets without LED #14881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9204d0
generic_tests update for targets without LED1
jeromecoutant Jul 6, 2021
64027e4
events-timing test should not need any LED1
jeromecoutant Jul 6, 2021
971d0dd
pin_names-generic test update before skipping it
jeromecoutant Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions drivers/tests/TESTS/mbed_drivers/generic_tests/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ void test_case_basic()
"The quick brown fox jumps over the lazy dog");
}

#ifdef LED1
void test_case_blinky()
{
static DigitalOut myled(LED1);
Expand All @@ -84,6 +85,7 @@ void test_case_blinky()
myled = !myled;
}
}
#endif

void test_case_cpp_stack()
{
Expand Down Expand Up @@ -113,7 +115,9 @@ utest::v1::status_t greentea_failure_handler(const Case *const source, const fai
// Generic test cases
Case cases[] = {
Case("Basic", test_case_basic, greentea_failure_handler),
#ifdef LED1
Case("Blinky", test_case_blinky, greentea_failure_handler),
#endif
Case("C++ stack", test_case_cpp_stack, greentea_failure_handler),
Case("C++ heap", test_case_cpp_heap, greentea_failure_handler)
};
Expand Down
3 changes: 0 additions & 3 deletions events/tests/TESTS/events/timing/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ float chisq(float sigma)


Timer timer;
DigitalOut led(LED1);

equeue_sema_t sema;

Expand Down Expand Up @@ -120,8 +119,6 @@ void semaphore_timing_test()
}

TEST_ASSERT_INT_WITHIN(5000, taken, delay * 1000);

led = !led;
}

equeue_sema_destroy(&sema);
Expand Down
4 changes: 2 additions & 2 deletions hal/tests/TESTS/pin_names/generic/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
Requirements specified in docs/design-documents/hal/0004-pin-names-general-guidelines.md
*/

#ifndef LED1
#error [NOT_SUPPORTED] Target is not following mbed-os pin names standard // Test is set as Skipped
#if !defined LED1 && !defined BUTTON1
#error [NOT_SUPPORTED] Target doesn't have any LED and BUTTON
#else

using namespace utest::v1;
Expand Down