Migrate nRF52840-DK to Arduino Uno pin names #14960

boraozgen · 2021-07-27T14:05:20Z

Summary of changes

Updates the pin names and removes the migration warning.

Impact of changes

Migration actions required

Documentation

None.

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Patater

Could do with a long description in the commit message. Otherwise, LGTM

0xc0170 · 2021-07-28T09:08:34Z

Please review travis failing pin validation

boraozgen · 2021-07-28T14:34:21Z

Well it fails with the old version too :) I think it has to do with how Nordic defines the pins, is gives errors like:

LED1 = p13 <-- legacy assignment; LEDs and BUTTONs must be #define'd
or
ARDUINO_UNO_A0 <-- ARDUINO_UNO_A0 not defined

when the script is run with -vvv.

What is the Nordic maintainer situation?

boraozgen · 2021-07-28T15:03:33Z

Fixed it. Moved some pins to #define from enum as required. Had to remove some whitespaces since the regex in the validation tool is pretty strict about it :)

Pull request has been modified.

0xc0170

second commit - can you add nRF52840-DK: prefix there.

Test passed so this hsould be ready for CI

boraozgen · 2021-07-29T14:30:19Z

Done

0xc0170 · 2021-07-30T10:51:04Z

CI started

mbed-ci · 2021-07-30T12:49:14Z

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

mbed-ci · 2021-07-30T12:49:25Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

0xc0170 · 2021-07-30T13:15:28Z

Pinmap test case failed, please review

boraozgen · 2021-07-30T13:38:31Z

For convenience, this is the failing test case:

mbed-os/hal/tests/TESTS/pin_names/arduino_uno/main.cpp

Lines 157 to 158 in 3318720

    
           int console_uart = pinmap_peripheral(CONSOLE_TX, serial_tx_pinmap()); 
        
           TEST_ASSERT_NOT_EQUAL(console_uart, pinmap_peripheral(TX_pin, serial_tx_pinmap()));

This case is bound to fail on Nordic boards as the peripherals can be muxed arbitrarily and serial_tx_pinmap of Nordic returns a dummy pinmap:

mbed-os/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/serial_api.c

Lines 1432 to 1435 in 3318720

    
           const PinMap *serial_tx_pinmap() 
        
           { 
        
               return PinMap_UART_testing; 
        
           }

How should we proceed?

0xc0170 · 2021-08-02T08:23:02Z

@gpsimenos can you review please?

gpsimenos

LGTM, I believe it's OK to ignore the failing test case.

0xc0170 · 2021-08-02T12:02:04Z

LGTM, I believe it's OK to ignore the failing test case.

This would start failing in our CI. Nordic pinmaping is valid so our test case should either consider this or we shall update testing pinmap set for Nordic to not be the same - I've noticed their uart pinmap is basically pXX, 0, 0 - if we set console uart to be non zero, would that fix the error ?

ciarmcom · 2021-08-11T11:50:20Z

This pull request has automatically been marked as stale because it has had no recent activity. @boraozgen, please carry out any necessary work to get the changes merged. Thank you for your contributions.

0xc0170 · 2021-08-12T14:57:47Z

@gpsimenos What else can we do with the test, nordic pinmap features seems to break the test (this is valid use case), so we should review the tests.

0xc0170 · 2021-10-04T09:45:37Z

I can see, checking what is causing this labeling :(

Adapted the file to the latest pin naming guidelines. pinvalidate.py passes.

Pull request has been modified.

0xc0170 · 2021-10-05T08:17:55Z

CI started

mbed-ci · 2021-10-05T09:32:33Z

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	❌

boraozgen · 2021-10-05T09:44:43Z

A similar issue seems to apply to the I2C test too :/

Failing test for convenience:

mbed-os/hal/tests/TESTS/pin_names/arduino_uno/main.cpp

Line 171 in 9dd6fb4

void I2C_test()

Edit: logs extract

[1633426311.97][CONN][RXD] >>> Running case #36: 'I2C'...
[1633426311.97][CONN][RXD] I2C SDA Pin 0x1a SCL Pin 0x1b
[1633426311.97][CONN][INF] found KV pair in stream: {{__testcase_start;I2C}}, queued...
mbedgt: :184::FAIL: Expected Not-Equal
[1633426312.03][CONN][RXD] :184::FAIL: Expected Not-Equal
[1633426312.03][CONN][INF] found KV pair in stream: {{__testcase_finish;I2C;0;1}}, queued...
[1633426312.20][CONN][RXD] >>> 'I2C': 0 passed, 1 failed with reason 'Assertion Failed'

Failing line:

mbed-os/hal/tests/TESTS/pin_names/arduino_uno/main.cpp

Line 184 in 9dd6fb4

TEST_ASSERT_NOT_EQUAL(NC, maps->pin);

jeromecoutant · 2021-10-05T09:47:56Z

A similar issue seems to apply to the I2C test too :/

Test is checking if the default I2C pins are in the I2C pin tables

boraozgen · 2021-10-05T09:49:28Z

Again, dummy pinmap is returned, which causes the fail:

mbed-os/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/i2c_api.c

Lines 219 to 227 in 3318720

    
           const PinMap *i2c_master_sda_pinmap() 
        
           { 
        
               return PinMap_I2C_testing; 
        
           } 
        
           const PinMap *i2c_master_scl_pinmap() 
        
           { 
        
               return PinMap_I2C_testing; 
        
           }

jeromecoutant · 2021-10-05T09:58:29Z

ARDUINO_UNO_D14 = p26,
ARDUINO_UNO_D15 = p27,

But why these pins are not part of PinMap_I2C_testing ???

0xc0170 · 2022-02-09T14:25:00Z

If we add these two to the testing pinmaps?

0xc0170 · 2022-03-08T16:16:04Z

I'll close this pull request. Please reopen with an update or add an issue to keep track of this.

Patater previously approved these changes Jul 27, 2021

View reviewed changes

mergify bot added the needs: work label Jul 27, 2021

0xc0170 reviewed Jul 29, 2021

View reviewed changes

nRF52840-DK: Migrate to Arduino Uno pin names

02862cb

boraozgen force-pushed the nrf52840-dk-pin-names branch from 5c6894b to 665d4e7 Compare July 29, 2021 14:29

0xc0170 previously approved these changes Jul 30, 2021

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jul 30, 2021

mergify bot added needs: work and removed needs: CI labels Jul 30, 2021

gpsimenos previously approved these changes Aug 2, 2021

View reviewed changes

ciarmcom added the stale Stale Pull Request label Aug 11, 2021

ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 13, 2021

ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 20, 2021

mergify bot added needs: work and removed needs: work labels Oct 4, 2021

0xc0170 reopened this Oct 4, 2021

mergify bot added needs: work and removed needs: work labels Oct 4, 2021

0xc0170 mentioned this pull request Oct 4, 2021

One/two actions are done repeatedly hundreds of times (label added and removed) Mergifyio/mergify#3307

Closed

nRF52840-DK: Fix pin validation

c77c85c

Adapted the file to the latest pin naming guidelines. pinvalidate.py passes.

boraozgen force-pushed the nrf52840-dk-pin-names branch from 665d4e7 to c77c85c Compare October 5, 2021 06:58

0xc0170 added needs: review and removed needs: work labels Oct 5, 2021

0xc0170 approved these changes Oct 5, 2021

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Oct 5, 2021

mergify bot added needs: work and removed needs: CI labels Oct 5, 2021

0xc0170 closed this Mar 8, 2022

mergify bot removed the needs: work label Mar 8, 2022

Migrate nRF52840-DK to Arduino Uno pin names #14960

Migrate nRF52840-DK to Arduino Uno pin names #14960

Uh oh!

Conversation

boraozgen commented Jul 27, 2021

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

Patater left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 28, 2021

Uh oh!

boraozgen commented Jul 28, 2021

Uh oh!

boraozgen commented Jul 28, 2021

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

boraozgen commented Jul 29, 2021

Uh oh!

0xc0170 commented Jul 30, 2021

Uh oh!

mbed-ci commented Jul 30, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

mbed-ci commented Jul 30, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

0xc0170 commented Jul 30, 2021

Uh oh!

boraozgen commented Jul 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 2, 2021

Uh oh!

gpsimenos left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Aug 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ciarmcom commented Aug 11, 2021

Uh oh!

0xc0170 commented Aug 12, 2021

Uh oh!

0xc0170 commented Oct 4, 2021

Uh oh!

0xc0170 commented Oct 5, 2021

Uh oh!

mbed-ci commented Oct 5, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

Uh oh!

boraozgen commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeromecoutant commented Oct 5, 2021

Uh oh!

boraozgen commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeromecoutant commented Oct 5, 2021

Uh oh!

0xc0170 commented Feb 9, 2022

Uh oh!

0xc0170 commented Mar 8, 2022

Uh oh!

Uh oh!

boraozgen commented Jul 30, 2021 •

edited

Loading

0xc0170 commented Aug 2, 2021 •

edited

Loading

boraozgen commented Oct 5, 2021 •

edited

Loading

boraozgen commented Oct 5, 2021 •

edited

Loading