Greentea: Fix flash overflown issue in callback_big test #15067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
rwalton-arm
reviewed
Sep 13, 2021
rajkan01
force-pushed
the
fix_flash_overflow_callback_big_test
branch
from
ed03ab3 to
4f6efb2
Compare
Patater
previously requested changes
Sep 13, 2021
rajkan01
force-pushed
the
fix_flash_overflow_callback_big_test
branch
from
4f6efb2 to
c5221ef
Compare
mergify
bot
dismissed
Patater’s stale review
Pull request has been modified.
The "Callback_big" greentea test has six test cases that require a minimum above 36kb ROM to build all test cases. LPC1114 target has only 32KB ROM memory, so the limit 6th test case to include or exclude based on the target minimum ROM size. Note: In LPC1114 target, callback_big test has ROM overflow build issue for both Mbed CLI1 and CLI2.
rajkan01
force-pushed
the
fix_flash_overflow_callback_big_test
branch
from
c5221ef to
77960d3
Compare
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The "Callback_big" greentea test has six test cases that require a minimum above 36kb ROM to build all test cases. LPC1114 target has only 32KB ROM memory, so the limit 6th test case to include or exclude based on the target minimum ROM size
Note:
In LPC1114 target, callback_big test has ROM overflow build issue for both Mbed CLI1 and CLI2.
Impact of changes
With these changes, Callback_big greentea test can avoid overflow ROM issue
Migration actions required
None.
Documentation
None.
Pull request type
Test results
Reviewers