Skip to content

Add Assertions for "Plus Sign Alias" Email Addresses #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2021

Conversation

shawnhooper
Copy link

@shawnhooper shawnhooper commented Jul 6, 2021

This pull request adds two assertions to support email addresses like:

myname+spam@example.com

This type of "plus sign alias" is supported by GMail, Office365, and several other providers. I couldn't find an official name for this feature, and am open to alternate naming suggestions.

New Assertions

EmailAssertions::assertPlusMailbox('myname, 'myname+spam@example.com')
EmailAssertions::assertPlusAlias('spam', 'myname+spam@example.com');

Copy link
Member

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution! 🙏
Pretty cool extension to that package. 🎉
Sorry for the delay, with a new job I didn't had much time for OSS during the last weeks. 😟

@Gummibeer Gummibeer merged commit c3e9fa3 into Astrotomic:main Jul 24, 2021
@Gummibeer
Copy link
Member

@shawnhooper
Copy link
Author

@Gummibeer Thanks for the merge Tom! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants