feat: template version display #4094
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please check the failed test, and make a (very brief) note of what caused it? |
I think my Playwright test failed because it couldn’t find the element in the about settings. Let me rewrite the test. |
webfiltered
reviewed
Jun 7, 2025
yiqun12
changed the title
yiqun12
changed the title
|
reopen |
webfiltered
requested changes
Jun 8, 2025
src/stores/aboutPanelStore.ts
Outdated
| const coreVersion = computed( | ||
| () => systemStatsStore?.systemStats?.system?.comfyui_version ?? '' | ||
| ) | ||
| const workflowsTemplatesVersion = computed( | ||
| () => | ||
| systemStatsStore?.systemStats?.system?.workflows_templates_version ?? '' |
There was a problem hiding this comment.
It looks like this is making two API calls now.
There was a problem hiding this comment.
hmm. I will double check and fix it later.
simplify computed version access with shared system reference
webfiltered
approved these changes
Jun 9, 2025
christian-byrne
requested changes
Jun 10, 2025
vite.config.mts
Outdated
Comment on lines
34
to
36
| '/templates_version': { | ||
| target: DEV_SERVER_COMFYUI_URL | ||
| }, |
There was a problem hiding this comment.
Why is this still here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4006
Key Changes
Version Fetching: In aboutPanelStore.ts, the templateVersionStore is used to asynchronously fetch the version of workflow_templates.
UI Update: A new badge is added to the coreBadges computed property in aboutPanelStore.ts to display the fetched version.
Link Addition: The badge not only shows the version but also links directly to the Comfy-Org/workflow_templates GitHub repo for quick access to the source code and changelog.
┆Issue is synchronized with this [Notion page] by Unito