Skip to content

Improved opacity support in Radial Gauge #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

XamlBrewer
Copy link
Contributor

This change adds support for Opacity in the brushes for the Radial Gauge elements that are drawn with the Composition API: Ticks, ScaleTicks, and Needle.

Fixes

To support transparency, apply the Opacity of the resource Brush to the Composition Visuals.

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Only the XAML elements (Scale, Trail, and the texts) currently support Opacity in their Brushes. Composition API elements (Ticks, ScaleTicks, and Needle) do not support transparency.

What is the new behavior?

All UI elements now react in a similar way to a resource Brush with Opacity.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [*] Tested code with current UWP and WinUI 3 versions.
  • [*] Contains NO breaking changes

Other information

This change adds support for Opacity in the brushes for the Radial Gauge elements that are drawn with the Composition API: Ticks, ScaleTicks, and Needle.
@ghost
Copy link

ghost commented Nov 15, 2021

Thanks XamlBrewer for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi November 15, 2021 13:04
@michael-hawker
Copy link
Member

Thanks @XamlBrewer! Sorry for the delay here we were doing some WinUI 3 work in November and then holidays and such.

I saw you made some base improvements for theming/input for WinUI 3, could those base improvements apply to the UWP version of the control as well? Would you be interested in contributing them back into the Toolkit as well?

We should hopefully have a single branch to better support UWP/WinUI 3 in the future, but we're still investigating that bit.

@XamlBrewer
Copy link
Contributor Author

Hi @michael-hawker, I believe that most if not all changes that I did during the WinUI 3 migration are indeed UWP compatible. I'll check it out and then open one of more extra pull requests.

@michael-hawker michael-hawker merged commit e4d65a0 into CommunityToolkit:main Dec 17, 2021
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants