refactor!: centralize sticky prompt and selection handling #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathbeam
force-pushed
the
use-sticky-better
branch
26 times, most recently
from
ceb2e98 to
3e5dedf
Compare
deathbeam
force-pushed
the
use-sticky-better
branch
3 times, most recently
from
fc55a95 to
0dea26f
Compare
deathbeam
force-pushed
the
use-sticky-better
branch
5 times, most recently
from
322ebe3 to
f55feef
Compare
deathbeam
changed the title
deathbeam
force-pushed
the
use-sticky-better
branch
4 times, most recently
from
0cc5798 to
17cf065
Compare
|
TODO: When doing .stop() and starting new prompt right after, for some reason stickies are not inherited |
deathbeam
force-pushed
the
use-sticky-better
branch
8 times, most recently
from
c2b1715 to
c3c205d
Compare
This refactoring improves the CopilotChat plugin's state management by: - Adding `insert_sticky` function to centralize sticky prompt management - Creating `set_selection` to provide a cleaner API for selection handling - Consolidating highlight management in `update_highlights` - Standardizing function signatures and return values - Improving `Chat:set_prompt` functionality - Removing redundant code for better maintainability BREAKING CHANGES: - `M.resolve_prompt` now returns config first and prompt second - `M.update_selection` removed in favor of new `M.set_selection` function - `M.resolve_embeddings` renamed to `M.resolve_context` - Selection setting now only configurable in global config, not per-operation - `get_selection` no longer accepts a config parameter - Selection handling moved from dynamic config to static global config - Changed sticky format and processing approach - Prompts in config now use explicit `sticky` property instead of prefixing Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
force-pushed
the
use-sticky-better
branch
from
c3c205d to
9621293
Compare
deathbeam
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring improves the CopilotChat plugin's state management by:
insert_stickyfunction to centralize sticky prompt managementset_selectionto provide a cleaner API for selection handlingupdate_highlightsChat:set_promptfunctionalityBREAKING CHANGES:
M.resolve_promptnow returns config first and prompt secondM.update_selectionremoved in favor of newM.set_selectionfunctionM.resolve_embeddingsrenamed toM.resolve_contextget_selectionno longer accepts a config parameterstickyproperty instead of prefixingCloses #716