chore: update flask latest version to 3.1.1 #13680
Closed
+2,744
−9,663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
changelog/no-changelog
github-actions
bot
added
the
changelog/no-changelog
github-actions
bot
requested review from
rachelyangdog,
emmettbutler and
quinna-h
2 tasks
emmettbutler
approved these changes
Jun 17, 2025
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 278 ± 4 ms. The average import time from base is: 277 ± 2 ms. The import time difference between this PR and base is: 0.3 ± 0.2 ms. The difference is not statistically significant (z = 1.98). Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-06-17 17:15:57 Comparing candidate commit e05be0f in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 506 metrics, 6 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
|
bm1549
requested review from
ZStriker19 and
mabdinur
and removed request for
rachelyangdog
ZStriker19
approved these changes
Jun 23, 2025
brettlangdon
force-pushed
the
upgrade-latest-flask-version
branch
from
e05be0f to
a7bd8d6
Compare
auto-merge was automatically disabled
June 25, 2025 19:43
Pull request was closed
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
+615
to
+616
| print(f"INFO: Excluding extension {ext.name}") | ||
| continue |
There was a problem hiding this comment.
🟠 Code Quality Violation
duplicate blocks between conditions (...read more)
Code in the branches of an if condition must be unique. If you have duplicated branches, merge the conditions.
| @@ -164,27 +156,15 @@ def _llmobs_set_meta_tags_from_embedding(span: Span, kwargs: Dict[str, Any], res | |||
| span._set_ctx_item(OUTPUT_VALUE, "[{} embedding(s) returned]".format(len(resp.data))) | |||
|
|
|||
| @staticmethod | |||
| def _extract_llmobs_metrics_tags(span: Span, resp: Any, span_kind: str) -> Dict[str, Any]: | |||
| def _extract_llmobs_metrics_tags(span: Span, resp: Any) -> Dict[str, Any]: | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
do not use Any, use a concrete type (...read more)
Use the Any type very carefully. Most of the time, the Any type is used because we do not know exactly what type is being used. If you want to specify that a value can be of any type, use object instead of Any.
Learn More
| instance: Any, | ||
| args: Sequence, | ||
| kwargs: dict, | ||
| vulnerability_type: VulnerabilityType, wrapped: Callable, instance: Any, args: Sequence, kwargs: dict |
There was a problem hiding this comment.
🟠 Code Quality Violation
do not use Any, use a concrete type (...read more)
Use the Any type very carefully. Most of the time, the Any type is used because we do not know exactly what type is being used. If you want to specify that a value can be of any type, use object instead of Any.
Learn More
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flask lockfiles and dependency package lockfiles.
This performs the following updates:
latest. This will update flask and dependencies.latestversion of another package. This will update all such packages.Checklist
Reviewer Checklist