-
Notifications
You must be signed in to change notification settings - Fork 441
chore: tidy to_unicode() in compat.py #13740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
172725f
to
3447253
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 272 ± 2 ms. The average import time from base is: 274 ± 2 ms. The import time difference between this PR and base is: -2.69 ± 0.07 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-24 07:50:22 Comparing candidate commit c22de04 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 558 metrics, 3 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspects-upper_aspect
scenario:iastaspectsospath-ospathjoin_aspect
|
As part of APMAPI-1159 this is to replace code that supports < python 3.8.
Removing comments about the
six
library as those are outdated.six
is a library to assist with python 2/3 compatibility.Kept duck typing for future proofing and to support bytearray.
Checklist
Reviewer Checklist