Localization extension - complex entity class hierarchies and projection to custom types

[beercsaba]

fix for #100

[alex-kulakov]

Thank you for the contribution but I have to request some changes.

The model is quite big but I see that not everything is in use. Is it minimal model to reproduce the issue? If it's not then shrink the model to make it minimal. If it is possible to use existing model types then use them. All tests inherited from Xtensive.Orm.Localization.Tests.AutoBuildTest recreate database schema of database so it is important to make models minimal to not waste test execution time.

We also have .editorconfig file so if your IDE supports it then notice what the IDE offers you to change(for instance using var ). We just started to move to new formatting so a lot of code use old formatting and we update it when edit files. New files should be with new one.

More changes will be requested in code review itself.

[beercsaba]

This PR was created badly, wrong branch was selected, so i've closed this PR and opened #102 but now with the appropriate branch.

[beercsaba]

Hi Alex! i've made model and unit test simpler and i've pushed it to my branch, but the new commit it was not applied to the pull request, I've realized that i made the pr with using wrong branch (from my fork), so i've closed that PR and created a new one (#102). Please continue work on this new PR. Sorry about my mistake! :( I hope You find my new model and test code simpler, clearer and better! :) best regards, Csaba Alexey Kulakov <notifications@github.com> ezt írta (időpont: 2020. dec. 1., K, 13:54):

…

Thank you for the contribution but I have to request some changes. The model is quite big but I see that not everything is in use. Is it minimal model to reproduce the issue? If it's not then shrink the model to make it minimal. If it is possible to use existing model types then use them. All tests inherited from Xtensive.Orm.Localization.Tests.AutoBuildTest recreate database schema of database so it is important to make models minimal to not waste test execution time. We also have .editorconfig file so if your IDE supports it then notice what the IDE offers you to change(for instance using var ). We just started to move to new formatting so a lot of code use old formatting and we update it when edit files. New files should be with new one. More changes will be required in code review itself. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#101 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF57T4RZNSKCBEAARSDXHRLSSTRPDANCNFSM4UGDTYAQ> .