Revision of tests that fail #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New codes have the same meaning so should be treated as UniqueConstraintViolation, not as Unknown
- Added indexes to the model - Changed filters for .Single() to actually return single value and not ruin tests - Certain First/FirstOrDefault() and Single/SingleOrDefault() tests were improved by adding new Asserts to them. - Some tests were ignored for MySql because they don't suppose to run against it - Split SelectStringContains() test into the one for case-sensitive and another for case-insensitive databases to prevent false fails
Tests were corrected due to the fact that some RDBMSs are unable to store full .Net DateTime (Mysql does not store milliseconds at all)
- MySQL is excluded from required providers - MainTest() was split to several tests per each tested query
Most RDBMSs have the same values for days of week as .Net, but not MySQL. It has the same order by Int values assigned with days of week start with 1.
MySQL does not support for default values for string fields with length longer than 4000
MySQL does not like long strings to be indexed
Remove copies of some classes that already exist in the tests framework like DomainConfigurationFactory or TestConfiguration and made tests of extensions be based on single AutoBuildTest from the tests framework. + minor changes
Plus code style improvements
Types that work in all RDBMSs are in X entity, those that specific to certain subset of RDBMSs are moved to separate Y and Z entities
as it done in master
also rename
150 items sequence will never be equal to 170 items sequence :)
Don't know whethere it should be for all the versions so left them as they were. The v11 does not require shemas to be upper case for sure
- some tests cases were ignored due to Oracle particularities - some broken test were fixed in order to fit Oracle limitations
The rest of storages have nulls order similar to .NET ordering algorithm so now Oracle v11 and above have the same order as .NET
It also fixed some issues with these operations
Basically they fail because they were written without oracle in mind. Some of them fail because of lack of feature check, others - because of bad design.
Native type for storing TimeSpans can be promoted to better precision later on, so let the problem be uncovered
# Conflicts: # Extensions/Xtensive.Orm.Reprocessing.Tests/Tests/Other.cs # Extensions/Xtensive.Orm.Reprocessing.Tests/Tests/Reprocessing.cs
+ domain correct domain disposal in case of exception and use .ToArray(count)
alex-kulakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR drops failed tests count for different storages. It was made by:
Full list of changes not connected with tests was added to changelog file for developing version. Note BREAKING CHANGE for Oracle:
NULLs in ordering column now have the same place as in .Net (nulls first for ascending and nulls last for descending order).Other changes:
WellKnownSchemasandWellKnownDatabasesinXtensive.Orm.Tests.Frameworkproject.Not all tests that failed were fixed by far. Some of them need a lot of time to investigate so they were skipped
Failed tests count drops for