Skip to content

Deprecate extend method on a component #48

Closed
@Igorbek

Description

@Igorbek

Reported by @Bdthomson in #33

I am running into the exact same issue with Backbone views such as this one:

MyView.extend({
...
})

produces

TypeError: MyView.extend.withConfig is not a function

Edit:
.extend was removed from styled-components in v4 (styled-components/styled- components#1908), is it possible to remove support for it in this plugin as well so you no longer have to maintain that transformation?

Put up a preliminary PR here - #47.

Suggested solution:

  • make extend identifier configurable like other identifiers;
  • set default value to an empty array;
  • add readme/release notes with breaking change information and instructions to re-enable by providing settings.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions