feat(no-topromise): suggest an exact replacement for toPromise() #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the "most correct" suggestion to
no-topromise
for replacingtoPromise()
.The old
toPromise()
would resolve toundefined
, while the newlastValueFrom
rejects withEmptyError
. So if a user followed the old top suggestion and replacedtoPromise
withlastValueFrom
, they might be surprised to findEmptyError
now thrown instead. This wouldn't be a problem for someone using thestrict
config, which includesno-ignored-default-value
, but users of therecommended
config wouldn't get that lint notification.Resolves #168