Skip to content

Don't require Finnish notation or Subject suffixes for forkJoin or combineLatest properties #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChrisMBarr
Copy link

This addresses #40 (as well as a personal annoyance for me!)

Before

combineLatest({
  number$: of(0),
  letterSubject$: new BehaviorSubject('a')
});

After

combineLatest({
  number: of(0),
  letter: new BehaviorSubject('a')
});

I am not sure if I did this in the best way possible or if this catches any/all edge cases. Please let me know if this can be improved somehow

ChrisMBarr and others added 3 commits May 26, 2025 18:04
- etc is a legacy folder for the inlined fork of the old `eslint-etc` package.  New utilities should go in utils.
- Also renamed the new utility to better indicate why certain functions are being allowlisted.
- Updated documentation.
Copy link
Owner

@JasonWeinzierl JasonWeinzierl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I moved the utility to a separate file (and other comments on the commit I pushed). Nice to have this annoyance fixed!

@JasonWeinzierl JasonWeinzierl merged commit ee9ec8e into JasonWeinzierl:main May 28, 2025
3 checks passed
@JasonWeinzierl
Copy link
Owner

This is released in v0.7.4

@ChrisMBarr ChrisMBarr deleted the fix-#40-whitelist-functions-skip-finnish branch May 28, 2025 11:56
@ChrisMBarr
Copy link
Author

Good changes, and good call updating the docs as I forgot about that!

This will solve a real annoyance for my team. We have a NestJS server that in many cases just combines observables and returns them. unless this rule was ignored then we'd have properties with Finnish notation returned in the JSON data of the API request. Today I'll be updating and going through to remove all of these rule disables!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants