-
Notifications
You must be signed in to change notification settings - Fork 3.5k
add autopep8 to Contributions guide #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@hadim ^^ something like this? |
Looks good to me. Thanks! |
In my test Also running |
Actually my command is wrong since it does not process the files... doing more tests now. |
Here is the correct command: |
Running it on
Edits are minor. Maybe you could include this in the PR. |
Sure, I have already applied the command as part of this PR but it creates change in the if statement which violate fake8 check...
That's better, thx |
You should be able to ignore specific lines of code with |
Sure, we are already using it in deprecated inits, but we shall not use this local fix for systematic issues lol |
Of course! Only for things that |
the problem was the if statement was not properly aligned on the next line so |
* add autopep8 to Contrib. * simplify cmd * update GH templates * add pytest-flake8 * update GH template
What does this PR do?
Fixes #53. Adding usage
autopep8
to guidelinesPR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃