fix: show error if occurs on plugin build #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
DimitarTachev
approved these changes
Apr 16, 2018
current behavior: when you run `npm i`, `prepare` is also run which results in running `tns plugin build`. Currently if the command fails, the user is not notified. updated behavior: if an error occurs during `npm plugin build`, error is shown.
radeva
force-pushed
the
radeva/show-plugin-build-error
branch
from
5d68e27 to
b330fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current behavior: when you run
npm i,prepareis also run which results in runningtns plugin build. Currently if the command fails, the user is not notified.updated behavior: if an error occurs during
npm plugin build, error is shown.