Skip to content

fix: relax starlette version requirement to resolve FastAPI conflict #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

umayado17
Copy link
Contributor

Description

This PR addresses the dependency conflict between Starlette versions required by core dependencies and FastAPI server features by relaxing the version constraints in pyproject.toml.

Changes Made

Modified pyproject.toml to update Starlette version requirement:

- starlette = "^0.37.2"
+ starlette = ">=0.37.2,<0.42.0"

Problem Solved

  • Resolves dependency conflicts between core Starlette requirement and FastAPI's Starlette requirement
  • Eliminates pip installation warnings while maintaining compatibility
  • Allows both core functionality and server features to work without version conflicts

Testing Done

  • Verified clean installation without dependency warnings
  • Tested core functionality remains intact
  • Confirmed server features work correctly with new version constraint

Related Issue

Closes #1505

@KillianLucas KillianLucas changed the base branch from main to development October 28, 2024 17:36
@KillianLucas
Copy link
Collaborator

Great fix, thanks @umayado17! Merging.

@KillianLucas KillianLucas merged commit 67cd175 into OpenInterpreter:development Oct 28, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency Conflict: Starlette Version Requirement Causes Conflicts with FastAPI
3 participants