Skip to content

[Accuracy diff No.28-29] Fix accuracy diff for paddle.linalg.norm API #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

[Accuracy diff No.28-29] Fix accuracy diff for paddle.linalg.norm API #197

merged 4 commits into from
May 29, 2025

Conversation

ooooo-create
Copy link
Contributor

在 Paddle 中，如果 axis 为 None，x 会被压缩成一维向量然后计算向量范数。在 pytorch 中 axis为 None，输入可以允许为 1D（向量范数） 或 2D（矩阵范数）。我们只需要将 x flatten 1D 之后传入对应的 torch 函数，if keepdim, reshape 会原来的形状

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 28, 2025

Thanks for your contribution!

@luotao1 luotao1 mentioned this pull request May 28, 2025
Open
cangtianhuang
cangtianhuang approved these changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@cangtianhuang cangtianhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改后，paddle.linalg.norm 配置是否能够全量通过测试？

@ooooo-create
Copy link
Contributor Author

修改后，paddle.linalg.norm 配置是否能够全量通过测试？

all linalg.norm config in 5_accuracy/accuracy_6.txt and 5_accuracy/accuracy_error_1.txt has passed
图片

cangtianhuang
cangtianhuang approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@cangtianhuang cangtianhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit e29d6d3 into PFCCLab:main May 29, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@cangtianhuang cangtianhuang cangtianhuang approved these changes

Assignees
No one assigned
Labels
contributor HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ooooo-create @wanghuancoder @cangtianhuang @luotao1