[Accuracy diff No.42、118] Fix accuracy diff for paddle.nn.functional.embedding API #73445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
/re-run all-failed |
ooooo-create
changed the title
… accuracy_embedding
ooooo-create
force-pushed
the
accuracy_embedding
branch
3 times, most recently
from
c49ca5f to
91df9aa
Compare
ooooo-create
requested review from
sneaxiy,
raindrops2sea and
ForFishes
as code owners
ooooo-create
force-pushed
the
accuracy_embedding
branch
from
91df9aa to
7bfabbb
Compare
|
/re-run all-failed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #73445 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 1
Lines ? 5
Branches ? 0
===========================================
Hits ? 5
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/re-run all-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
Pytorch 中 padding_idx 并不会导致前向输出为 0，会保持为原来的 weight，只是反向不会贡献对应 weight 的梯度，所以前向 kernel 不需要考虑 padding_idx 的值
https://docs.pytorch.org/docs/stable/generated/torch.nn.functional.embedding.html
https://github.com/pytorch/pytorch/blob/6959b5febe090375e261e678902681533d2e2528/aten/src/ATen/native/Embedding.cpp#L37-L55
PaddleAPITest 测试通过
TODO