[SOT] Check without graph for fallback code only #73515
Open
+3
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
我们目前有一个策略,就是针对一个 code,如果连续多次都没有感知到其内有 graph,就直接回退到动态图,这个目前主要针对的应该是有 fallback 的场景,而非 fallback,也就是生成了 code 的场景,一般不会没有 graph,就算没有,也应该是在新的 code 里处理而不是在这里
目前处理方式是有问题的,
StepInfoManager
是为每个 original code 来记录 step count,但实际记录的分别如下:这里两者 step 记录的不匹配导致出现如下问题
这里问题只出现在非 fallback 的情况,fallback 的情况因为记录的 code 是统一的,因此不会出问题
而非 fallback 的情况已经生成 code 了,一般不会没有 graph,因此本 PR 移除对该 case 的处理,仅针对 fallback case