Skip to content

Fix final train loss. #8718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix final train loss. #8718

wants to merge 2 commits into from

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Jul 5, 2024

PR types

Others

PR changes

Others

Description

此PR删除了日志,导致恢复之后,最后算的平均loss值等发生了问题。
#8546

Copy link

paddle-bot bot commented Jul 5, 2024

Thanks for your contribution!

@ZHUI ZHUI changed the title Update trainer.py Fix final train loss. Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.77%. Comparing base (d8ddba9) to head (27376fc).
Report is 578 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8718      +/-   ##
===========================================
+ Coverage    55.73%   55.77%   +0.04%     
===========================================
  Files          623      626       +3     
  Lines        97464   101574    +4110     
===========================================
+ Hits         54324    56657    +2333     
- Misses       43140    44917    +1777     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI ZHUI requested a review from sneaxiy July 12, 2024 06:50
Copy link

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added stale and removed stale labels Sep 11, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ZHUI ZHUI closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants