Skip to content

[Benchmark] Fix amp level bug in some gpt tests #9116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 13, 2024
Merged

[Benchmark] Fix amp level bug in some gpt tests #9116

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ca8e20
add
zhangbo9674 Sep 10, 2024
7523be7
refine
zhangbo9674 Sep 11, 2024
1239dd6
refine
zhangbo9674 Sep 11, 2024
21d19f3
refine
zhangbo9674 Sep 11, 2024
0d79fdc
refine
zhangbo9674 Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...o/gpt-3/benchmarks/test_tipc/gpt/static/new_exec_pp_pir/benchmark_common/run_benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ function _set_params(){
sharding_degree=${10:-"1"} # (可选)
sharding_stage=${11:-"1"} # (可选)sharding case
level=${12:-"o1"} # o1|o2|o3

if [ $FLAGS_enable_pir_api == 1 ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改成这样吧， if [[ $FLAGS_enable_pir_api == "1" || $FLAGS_enable_pir_api == "True" ]]; then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

if [ ${level} == "o3" ]; then
${level}="o2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是 level="o2"吧？

echo "amp level changed to o2 in pir mode"
else
echo "amp level is o3"
fi
else
echo "FLAGS_enable_pir_api = 0"
fi

local_batch_size=${13:-"8"} # （可选）本地batch size
schedule_mode=${14:-"1F1B"} # （可选）schedule mode
base_batch_size=$global_batch_size
Expand Down
Loading