Skip to content

【Hackathon 8th No.23】RFC:Improved Training of Wasserstein GANs 论文复现 #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025

Conversation

XvLingWYY
Copy link
Contributor

rfc修改
去除了FID评估指标因为论文中没有涉及
优化模型结构和代码逻辑,使结构与其他example相似

Copy link

paddle-bot bot commented Apr 26, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@XvLingWYY
Copy link
Contributor Author

@robinbg

Copy link
Collaborator

@lijialin03 lijialin03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交~这个修改后的代码格式确实更符合PaddleScience所需要的格式,不过由于当前阶段我们鼓励多提交代码,对格式要求比较一般,因此按照PaddleScience所需要的格式是最好的,如果确实不能达到,只要使用了ppsci库中的api也可以接受。
因此这个RFC暂时hold,但必须说明的是,我们依然鼓励按照PaddleScience所需要的格式实现代码,谢谢!

@luotao1
Copy link
Collaborator

luotao1 commented Apr 27, 2025

@XvLingWYY 可以先把PR按照你修改后的代码格式,提交上来

@XvLingWYY
Copy link
Contributor Author

好的,谢谢老师

@lijialin03
Copy link
Collaborator

这个rfc已经跟最后实现稍微有点不同了,麻烦现在再改一下吧

@XvLingWYY
Copy link
Contributor Author

好的,谢谢老师已完成修改

Copy link
Collaborator

@lijialin03 lijialin03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit aa7623e into PaddlePaddle:master May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants