-
Notifications
You must be signed in to change notification settings - Fork 288
【Hackathon 8th No.23】RFC:Improved Training of Wasserstein GANs 论文复现 #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢提交~这个修改后的代码格式确实更符合PaddleScience所需要的格式,不过由于当前阶段我们鼓励多提交代码,对格式要求比较一般,因此按照PaddleScience所需要的格式是最好的,如果确实不能达到,只要使用了ppsci库中的api也可以接受。
因此这个RFC暂时hold,但必须说明的是,我们依然鼓励按照PaddleScience所需要的格式实现代码,谢谢!
@XvLingWYY 可以先把PR按照你修改后的代码格式,提交上来 |
好的,谢谢老师 |
这个rfc已经跟最后实现稍微有点不同了,麻烦现在再改一下吧 |
好的,谢谢老师已完成修改 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rfc修改
去除了FID评估指标因为论文中没有涉及
优化模型结构和代码逻辑,使结构与其他example相似