Operations to rewrite

[akarnokd]

Core:

• All (w/ lift) PR OperatorAll #1061 - Merged
• Any (w/ lift) PR OperatorAny #1062 - Merged
  • Exist and IsEmpty are built upon Any
• AsObservable (w/ OnSubscribe lift) PR Operator AsObservable #1064 - Merged
• Buffer (w/ lift) PR OperatorBuffer #1073 - Merged
  • size, time window, skip, observable boundary, observable start-end
• CombineLatest (w/ OnSubscribe) PR OperatorCombineLatest #1079 - Merged
• Concat (w/ OnSubscribe lift) PR OperatorConcat #1074 - Merged
• Debounce (w/ lift) PR Operator debounce2 #1094
  • time window, another observable
• DefaultIfEmpty (w/ lift) PR OperatorDefaultIfEmpty #1080 - Merged
• Defer (w/ OnSubscribe) PR OperatorDefer #1081 - Merged
• Delay (w/ lift keep as is) PR OperatorDelay #1093 PR Operator Delay rebase & fixes #1144
  • DelaySubscribe (w/ OnSubscribe)
  • DelayViaObservable (w/ OnSubscribe)
• Dematerialize (w/ lift) PR OperatorDematerialize #1083 - Merged
• Distinct (w/ lift) PR OperatorDistinct #1084 - Merged
  • regular, custom equality comparator
• DistinctUntilChanged (w/ lift) PR OperatorDistinctUntilChanged #1085 - Merged
• FinallyDo (w/ lift) PR OperatorFinallyDo #1086 - Merged
• FlatMap (w/ lift) -> rename to MergeMap PR OperatorMergeMap #1087 - Merged
  • regular, with iterator as sub-collection (MergeMapIterable)
• GroupByUntil (w/ lift) PR OperatorGroupByUntil #1095
• GroupJoin (w/ OnSubscribe) PR OperatorGroupJoin #1096
• Interval replace with Timer PR OperatorTimerAndSample #1098
• Join (w/ OnSubscribe) PR OperatorJoin #1103
• MergeDelayError (w/ lift) PR Operator merge delay error #1104
• MergeMaxConcurrent(w/ lift) PR OperatorMergeMaxConcurrent #1106
• Multicast (w/ OnSubscribe); PR OperatorMulticastAndReplay #1108
  • regular, factory+selector
• OnErrorResumeNextViaObservable (w/ lift) PR OperatorOnErrorResumeNextViaObservable #1109
• OnErrorReturn(w/ lift) PR OperatorOnErrorReturn #1110
• OnExceptionResumeNextViaObservable (w/ lift) PR Operator OnExceptionResumeNextViaObservable #1117
• ParallelMerge -> just rename PR Operator ParallelMerge #1118
• RefCount (w/ OnSubscribe) PR OperatorRefCount #1119
• Replay (w/ OnSubscribe) PR OperatorMulticastAndReplay #1108
• Sample (w/ lift) PR OperatorTimerAndSample #1098
  • time (state-sharing bug!), another Observable
• SequenceEquals -> just rename PR OperatorSequenceEqual #1120
• Skip (w/ lift) into OperatorSkipTimed PR OperatorSkipTimed #1121
• SkipUntil (w/ lift) PR OperatorSkipUntil #1122
• Switch (w/ lift) PR Operator Switch #1130
• Take (w/ lift) PR Operator TakeTimed #1131
  • count: already present, time
• TakeLast (w/ lift) PR OperatorTakeLast #1134
  • count, time
• TakeUntil (w/ lift) PR OperatorTakeUntil #1135
• TakeWhile (w/ lift); remove indexed variant? PR OperatorTakeWhile #1115
• ThrottleFirst (w/ lift) PR OperatorThrottleFirst #1112
• TimeInterval (w/ lift) PR OperatorTimeInterval #1111
• Timer (w/ OnSubscribe) PR OperatorTimerAndSample #1098
• ToMap (w/ OnSubscribe) PR OperatorToMap #1099
• ToMultimap (w/ OnSubscribe) PR OperatorToMultimap #1097
• ToObservableFuture (w/ OnSubscribe) PR OperatorToObservableFuture #1088 - Merged
• Using (w/ OnSubscribe) PR OperatorUsing #1100
• Window (w/ lift) PR Operator Window #1123, PR Operator Window and other changes #1138
  • size, time window, skip, observable boundary, observable start-end

contrib-string

• Optionally: refactor operators into separate classes. No changes.

contrib-async-util, PR #1101

• StartFuture -> just rename
• OperationFromFunctionals.InvokeAsync (w/ OnSubscribe)
• ForEachFuture -> just rename
• DeferFuture -> just rename

contrib-math, PR #1125

• Average (w/ lift); may keep current op-composition
  • int, long, float, double; w/ extractor function
• Min, MinBy, Max, MaxBy (w/ lift); may keep current op-composition
• Sum (w/ lift); may keep current op-composition

contrib-computation-expressions, PR #1129

• IfThen (w/ OnSubscribe)
• SwitchCase (w/ OnSubscribe)
• DoWhile, WhileDo (w/ OnSubscribe)

contrib-joins

• When (w/ OnSubscribe) PR Operator When #1126

[akarnokd]

I'm working on Buffer but still have to hunt down some test failures.

[DavidMGross]

Do we expect any of the following proposed operators to be revived?

• chunkify
• deferCancellableFuture (rxjava-async)
• doWhile
• forEachFuture (BlockingObservable)
• forIterable
• fromCancellableFuture (rxjava-async)
• fromFuture
• generate
• generateAbsoluteTime
• ifThen
• startCancellableFuture (rxjava-async)
• switchCase
• whileDo

On Tue, Apr 22, 2014 at 7:50 AM, akarnokd notifications@github.com wrote:

I'm working on Buffer but still have to hunt down some test failures.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1060#issuecomment-41049048
.

David M. Gross
PLP Consulting

[akarnokd]

ifThen, switchCase, doWhile, whileDo are in contrib-computation-expressions

I'm not sure about the CancelableFuture variants as they conceptionally didn't really work in Java (i.e., attempt to mirror C# cancellation tokens)

chunkify, generate, generateAbsoluteTIme, forIterable - probably not.

While we are at it, I have some trouble with buffer(Func0<Observable>) variant. I would expect the returned Observable to supply multiple "absolute" boundary events, but the current implementation calls for a new Observable whenever a previous one fired an event, causing an exponential explosion ChunkedOperation L515. The reason seems to be to produce a relative windowing in the associated test method.

[benjchristensen]

Before we proceed, please review what I wrote at #1001 (comment) and let's agree upon the coding principles.

[benjchristensen]

Do we expect any of the following proposed operators to be revived?

I doubt it. Let's get the current operators (as of 0.18) polished for 1.0. New operators, or matured ones from the contrib modules, can come over in 1.x releases if found to be commonly needed.

The only one not on the list I can think of needing to re-add is the groupBy overload that takes a selector. It was unceremoniously dropped a few releases ago when I did refactoring.

[akarnokd]

I skipped combineLatest as there was PR #1043 not long ago; I wonder if @vigdorchik still wants to implement it.

[vigdorchik]

@akarnokd sorry, I'm out of context here.