Skip to content

Avoiding OperatorObserveOn from calling subscriber.onNext(..) after unsu... #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,13 @@ private static final class ObserveOnSubscriber<T> extends Subscriber<T> {
= AtomicLongFieldUpdater.newUpdater(ObserveOnSubscriber.class, "counter");

public ObserveOnSubscriber(Scheduler scheduler, Subscriber<? super T> subscriber) {
super(subscriber);
this.observer = subscriber;
this.recursiveScheduler = scheduler.createWorker();
this.scheduledUnsubscribe = new ScheduledUnsubscribe(recursiveScheduler);
subscriber.add(scheduledUnsubscribe);
add(scheduledUnsubscribe);

subscriber.add(recursiveScheduler);
subscriber.add(this);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import rx.Observable;
import rx.Observer;
import rx.Scheduler;
import rx.Subscription;
import rx.exceptions.TestException;
import rx.functions.Action0;
import rx.functions.Action1;
Expand Down Expand Up @@ -389,4 +390,21 @@ public void testDelayedErrorDeliveryWhenSafeSubscriberUnsubscribes() {
inOrder.verify(o, never()).onNext(anyInt());
inOrder.verify(o, never()).onCompleted();
}

@Test
public void testAfterUnsubscribeCalledThenObserverOnNextNeverCalled() {
final TestScheduler testScheduler = new TestScheduler();
final Observer<Integer> observer = mock(Observer.class);
final Subscription subscription = Observable.from(1, 2, 3)
.observeOn(testScheduler)
.subscribe(observer);
subscription.unsubscribe();
testScheduler.advanceTimeBy(1, TimeUnit.SECONDS);

final InOrder inOrder = inOrder(observer);

inOrder.verify(observer, never()).onNext(anyInt());
inOrder.verify(observer, never()).onError(any(Exception.class));
inOrder.verify(observer, never()).onCompleted();
}
}