[py] Return HTTP response reason when remote connection error occurs #15942
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
Fixes #15931
💥 What does this PR do?
This PR updates the
_request
method inRemoteConnection
, so an HTTP response reason is returned when a Remote WebDriver server returns an HTTP error.Previously, if an HTTP response was returned with a status code >= 500 that had no response body, it would return a blank
value
. With this update, any HTTP error (response code >= 400) will return the response reason as thevalue
. This will lead to more clear exceptions being raised when this occurs (previously it would raise an exception with a blank message).🔄 Types of changes
PR Type
Bug fix
Description
Return HTTP response reason for remote connection errors
Improve error handling for status codes >= 400
Provide clearer exception messages for HTTP errors
Changes walkthrough 📝
remote_connection.py
Improve HTTP error response handling
py/selenium/webdriver/remote/remote_connection.py
399 < statuscode <= 500
tostatuscode >= 400