Skip to content

missing tab in options.en.md #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2023
Merged

missing tab in options.en.md #1386

merged 3 commits into from
May 26, 2023

Conversation

gulifeng8
Copy link
Contributor

@gulifeng8 gulifeng8 commented May 11, 2023

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented May 11, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit a07ffc3
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/64707a1cb7357a000886a74a
😎 Deploy Preview https://deploy-preview-1386--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@diemol diemol left a comment

harsha509 added a commit that referenced this pull request May 26, 2023
@harsha509
Copy link
Member

Hi @gulifeng8 ,

Thank you for the PR. I have made similar changes in other translated pages referring your commit.

Thanks,
Sri Harsha

@harsha509 harsha509 merged commit cebb7f2 into SeleniumHQ:trunk May 26, 2023
@harsha509
Copy link
Member

Congratulations on your first contribution to selenium-docs @gulifeng8 🎉 🎉

selenium-ci added a commit that referenced this pull request May 26, 2023
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> cebb7f2
@gulifeng8 gulifeng8 deleted the patch-1 branch May 26, 2023 12:41
@gulifeng8
Copy link
Contributor Author

Thanks for everyone's effort, sorry for off-line some days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants