Update DIRECTORY.md with Newly Added Files #6302
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahul-18r
requested review from
DenizAltunkapan,
yanglbme,
vil02,
BamaCharanChhandogi,
alxkm and
siriak
as code owners
|
Note: .gitignore changes were committed by mistake but have been reverted. Please ignore them in the review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6302 +/- ##
============================================
- Coverage 74.16% 74.15% -0.01%
+ Complexity 5362 5361 -1
============================================
Files 678 678
Lines 18686 18686
Branches 3625 3625
============================================
- Hits 13858 13857 -1
Misses 4273 4273
- Partials 555 556 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DenizAltunkapan
requested changes
Jun 19, 2025
|
@Rahul-18r If you want to contribute more, I recommend checking out our issues ;) |
|
That was removed by mistake.
…On Thu, 19 Jun, 2025, 7:32 pm Deniz Altunkapan, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good!
------------------------------
In .gitignore
<#6302 (comment)>:
> @@ -42,5 +42,3 @@ local.properties
gradle.properties
.vscode
*.log
-
-/infer-out/
why did you remove this?
------------------------------
On DIRECTORY.md
<#6302 (comment)>:
looks good!
—
Reply to this email directly, view it on GitHub
<#6302 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAGYCIIMO2EJDFXT6TOEOET3EK7HRAVCNFSM6AAAAAB7VUPPLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNBTGE2TSOBYGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yeah, Sorry about the .gitignore change — that was a mistake while working
locally.
Thanks for sharing the issues, I’ll go through them and pick one to
contribute. Appreciate the help!
…On Thu, 19 Jun, 2025, 8:14 pm Rahul, ***@***.***> wrote:
That was removed by mistake.
On Thu, 19 Jun, 2025, 7:32 pm Deniz Altunkapan, ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
>
> Looks good!
> ------------------------------
>
> In .gitignore
> <#6302 (comment)>:
>
> > @@ -42,5 +42,3 @@ local.properties
> gradle.properties
> .vscode
> *.log
> -
> -/infer-out/
>
> why did you remove this?
> ------------------------------
>
> On DIRECTORY.md
> <#6302 (comment)>:
>
> looks good!
>
> —
> Reply to this email directly, view it on GitHub
> <#6302 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BAGYCIIMO2EJDFXT6TOEOET3EK7HRAVCNFSM6AAAAAB7VUPPLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNBTGE2TSOBYGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Rahul-18r
commented
Jun 19, 2025
|
Hey @DenizAltunkapan,
The .gitignore change was by mistake. Can we please ignore it for this PR?
I’ll avoid this in the future. Thanks!
…On Fri, 20 Jun, 2025, 6:19 pm Deniz Altunkapan, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .gitignore
<#6302 (comment)>:
> @@ -42,5 +42,3 @@ local.properties
gradle.properties
.vscode
*.log
-
-/infer-out/
there are still changes in the .gitignore @Rahul-18r
<https://github.com/Rahul-18r> . Could you explain these?
—
Reply to this email directly, view it on GitHub
<#6302 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAGYCIJXKTODXPNIMUPH4QT3EP7OXAVCNFSM6AAAAAB7VUPPLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNBWGAYDENJXGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I’ve updated the file and committed the changes. All checks are passing now. Sorry for the earlier issues, this is my first time contributing. I’ll be more careful next time.
________________________________
From: Andrii Siriak ***@***.***>
Sent: 20 June 2025 22:55
To: TheAlgorithms/Java ***@***.***>
Cc: Rahul ***@***.***>; Mention ***@***.***>
Subject: Re: [TheAlgorithms/Java] Update DIRECTORY.md with Newly Added Files (PR #6302)
@siriak commented on this pull request.
________________________________
In .gitignore<#6302 (comment)>:
@@ -42,5 +42,3 @@ local.properties
gradle.properties
.vscode
*.log
-
-/infer-out/
@Rahul-18r<https://github.com/Rahul-18r> you will need to revert this change, we cannot merge it in. You can update file in your branch and the change will be reflected in this pull request
—
Reply to this email directly, view it on GitHub<#6302 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BAGYCIMOTOISXFHWF64R6MT3EQ7YZAVCNFSM6AAAAAB7VUPPLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNBWHA4DKOBTHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
DenizAltunkapan
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-format -i --style=file path/to/your/file.java