Skip to content

Add Keynote to PDF conversion utilities for Cortex Cognitive Indexes #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ademgcl
Copy link
Collaborator

@ademgcl ademgcl commented Apr 7, 2025

This pull request includes several updates to the helper-apps/cortex-file-converter directory, primarily focusing on adding utilities for converting Apple Keynote (.key) files to PDF format and processing files stored in Azure Blob Storage. The most important changes are the addition of new scripts for handling the conversion and listing blob extensions, as well as updates to the README file and requirements.

New utilities and scripts:

Dependency updates:

@ademgcl ademgcl requested a review from Copilot April 7, 2025 11:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • helper-apps/cortex-file-converter/requirements.txt: Language not supported
Comments suppressed due to low confidence (3)

helper-apps/cortex-file-converter/process_azure_keynotes.py:96

  • [nitpick] Consider making 'container_name' configurable via an environment variable or a command-line argument to allow greater flexibility in different deployment environments.
container_name = "cortex-entity-indexed"

helper-apps/cortex-file-converter/process_azure_keynotes.py:82

  • [nitpick] Consider narrowing the scope of the exception handling to log more detailed context, which can help with debugging without masking specific issues.
except Exception as e:

helper-apps/cortex-file-converter/key_to_pdf.py:27

  • [nitpick] Consider refining this log message to clarify that an existing output file was removed as a preparatory step for conversion, improving log clarity.
print(f"Removed existing output file: {pdf_path}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant