Skip to content

Use <md-icon> instead of <i class="material-icons"> in demos. #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2016
Merged

Use <md-icon> instead of <i class="material-icons"> in demos. #345

merged 3 commits into from
Apr 26, 2016

Conversation

dozingcat
Copy link
Contributor

Also removed vertical-align in mdIcon styles because it causes the button icons to be misaligned.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 24, 2016
@kara kara added the pr: lgtm label Apr 24, 2016
@jelbourn
Copy link
Member

LGTM, just needs rebase

@dozingcat
Copy link
Contributor Author

Done. @kara might want to double check the merges.

@@ -107,7 +107,7 @@ $md-mini-fab-padding: 8px !default;
height: $size;
padding: 0;

i {
md-icon {
Copy link
Contributor

@kara kara Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be i, as well as md-icon (both)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kara
Copy link
Contributor

kara commented Apr 26, 2016

LGTM

@jelbourn jelbourn merged commit a9bc5fa into angular:master Apr 26, 2016
@dozingcat dozingcat deleted the mdicon_in_demos branch April 26, 2016 18:43
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants