Skip to content

chore: update to angular RC4 and other update other packages #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 12, 2016

Conversation

jelbourn
Copy link
Member

This removes the following deleted / deprecated APIs:

  • Angular's exported versions of describe, it, beforeEach, expect, etc.
  • beforeEachProviders, provide(...) and new Provider(...)
  • injectAsync
  • Remove jasmine matchers that came from angular/angular

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: needs review labels Jul 11, 2016
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 11, 2016
@hansl hansl added the pr: lgtm label Jul 11, 2016
@hansl
Copy link
Contributor

hansl commented Jul 11, 2016

LGTM.

@jelbourn
Copy link
Member Author

CC @robertmesserle @devversion @iveysaur

"@angular/core": "2.0.0-rc.4",
"@angular/http": "2.0.0-rc.4",
"@angular/platform-browser": "2.0.0-rc.4",
"@angular/platform-browser-dynamic": "2.0.0-rc.4",
"@angular/router": "v3.0.0-alpha.8",
"@angular/forms": "^0.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update forms to 0.2.0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried this, and some tests start failing. We can do that update in a separate PR.

@kara
Copy link
Contributor

kara commented Jul 11, 2016

We should probably update the package.jsons of form-related components to use 0.2.0:
https://github.com/angular/material2/blob/master/src/components/checkbox/package.json

Otherwise looks good

@jelbourn jelbourn force-pushed the cli-version branch 2 times, most recently from d9d7a8d to e326b54 Compare July 11, 2016 23:29
@iveysaur
Copy link
Contributor

LGTM, tests for gridlist are failing in this PR but I'm not sure if they are related to the change you made.

@jelbourn
Copy link
Member Author

Currently some grid-list tests are failing on iOS8. Seems like they were never running before and I accidentally fixed them. Debugging...

@jelbourn jelbourn force-pushed the cli-version branch 15 times, most recently from 1e6bcfe to 12cba5f Compare July 12, 2016 22:04
@jelbourn jelbourn merged commit e0284d4 into angular:master Jul 12, 2016
@jelbourn jelbourn deleted the cli-version branch September 13, 2017 04:33
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants