-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: update to angular RC4 and other update other packages #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM. |
"@angular/core": "2.0.0-rc.4", | ||
"@angular/http": "2.0.0-rc.4", | ||
"@angular/platform-browser": "2.0.0-rc.4", | ||
"@angular/platform-browser-dynamic": "2.0.0-rc.4", | ||
"@angular/router": "v3.0.0-alpha.8", | ||
"@angular/forms": "^0.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update forms to 0.2.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried this, and some tests start failing. We can do that update in a separate PR.
We should probably update the package.jsons of form-related components to use Otherwise looks good |
d9d7a8d
to
e326b54
Compare
LGTM, tests for gridlist are failing in this PR but I'm not sure if they are related to the change you made. |
Currently some grid-list tests are failing on iOS8. Seems like they were never running before and I accidentally fixed them. Debugging... |
db26953
to
ae92743
Compare
1e6bcfe
to
12cba5f
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This removes the following deleted / deprecated APIs:
describe
,it
,beforeEach
,expect
, etc.beforeEachProviders
,provide(...)
andnew Provider(...)
injectAsync
angular/angular