Skip to content

pre-commit: add gitleaks to detect hardcoded secrets #11064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbampton
Copy link
Member

Description

This PR adds another check / hook / test to our pre-commit framework

Closes #10978

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally pre-commit run --all-files

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (5b7c3b4) to head (0bc8f28).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11064   +/-   ##
=========================================
  Coverage     16.57%   16.57%           
  Complexity    13967    13967           
=========================================
  Files          5743     5743           
  Lines        510468   510468           
  Branches      62073    62073           
=========================================
  Hits          84616    84616           
+ Misses       416390   416389    -1     
- Partials       9462     9463    +1     
Flag Coverage Δ
uitests 3.90% <ø> (ø)
unittests 17.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit hook gitleaks to detect and prevent hardcoded secrets
2 participants