-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix fsvm-init.yml to detect virtio-scsi in kvm #11070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. One minor comment.
plugins/storage/sharedfs/storagevm/src/main/resources/conf/fsvm-init.yml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11070 +/- ##
=========================================
Coverage 16.57% 16.57%
Complexity 13967 13967
=========================================
Files 5743 5743
Lines 510468 510468
Branches 62073 62073
=========================================
Hits 84616 84616
Misses 416390 416390
Partials 9462 9462
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13906 |
Description
This PR about the sharedFS VM not functional while systemvm has been configured to use scsi as rootDiskController, this change added controller detection logic during init state.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested on OL9 KVM configuration for systemvm with rootDiskController=scsi configuration
How did you try to break this feature and the system with this change?