Skip to content

docs: update contributing docs #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2021
Merged

docs: update contributing docs #117

merged 3 commits into from
Oct 22, 2021

Conversation

andrewthetechie
Copy link
Contributor

Add some docs on how to run a postgres instance via docker-compose

This also removes the mssql server from the docker-compose file in
tests. It currently does not work (the service crashes) and isn't needed
for tests to succeed

Add some docs on how to run a postgres instance via docker-compose

This also removes the mssql server from the docker-compose file in
tests. It currently does not work (the service crashes) and isn't needed
for tests to succeed
@vercel
Copy link

vercel bot commented Oct 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/5iCxSayd4ra166ThewjJtW1NkaBK
✅ Preview: https://fastapi-crudrouter-git-fork-andrewthetechie-devel-df602b-flortz.vercel.app

Copy link
Owner

@awtkns awtkns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @andrewthetechie! 🚀

fyi MSSQL will be re-enable (and working) once #112 is merged.

@andrewthetechie
Copy link
Contributor Author

Thanks so much for this @andrewthetechie! 🚀

fyi MSSQL will be re-enable (and working) once #112 is merged.

You're welcome! I'm working on a new backend implementation to use pydantic-aioredis and ran into trouble while setting up tests. I figured if I ran into trouble, someone else would too so I might as well share it forward :)

@awtkns awtkns merged commit d89837d into awtkns:master Oct 22, 2021
@andrewthetechie andrewthetechie deleted the development-documentation branch October 22, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants