Skip to content

fix: miss the effects types #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025
Merged

fix: miss the effects types #5027

merged 5 commits into from
Jun 26, 2025

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Jun 25, 2025

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent requested a review from Copilot June 25, 2025 09:41
Copilot

This comment was marked as outdated.

@kobenguyent kobenguyent requested a review from Copilot June 25, 2025 09:48
Copilot

This comment was marked as outdated.

@kobenguyent kobenguyent requested a review from Copilot June 25, 2025 10:07
Copilot

This comment was marked as outdated.

@kobenguyent kobenguyent requested a review from thomashohn June 25, 2025 11:25
@kobenguyent kobenguyent requested a review from Copilot June 25, 2025 11:26
Copilot

This comment was marked as outdated.

@kobenguyent kobenguyent requested a review from Copilot June 25, 2025 14:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing type definitions for effects by adding new type tests and updating configuration files.

  • Adds tests to verify that tryTo functions return promises with boolean values.
  • Updates the JSDoc configuration to include the new effects module.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
typings/tests/global-variables.types.ts Added type tests for tryTo functions to ensure they return Promise
typings/jsdoc.conf.js Included the effects module to generate documentation for new types

@kobenguyent kobenguyent merged commit 926a36a into 3.x Jun 26, 2025
12 checks passed
@kobenguyent kobenguyent deleted the fix-missing-effects-types branch June 26, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing TS definition for effects: Cannot find module 'codeceptjs/effects' or its corresponding type declarations
1 participant