Add warnings import for deprecated messages #668
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue reported here - #239
Fix Missing Warnings Import for Deprecated Protobuf Messages
Issue
When using deprecated protobuf messages or fields, betterproto generates code that calls
warnings.warn()
but was missing the requiredimport warnings
statement. This causedNameError: name 'warnings' is not defined
when deprecated features were used.Root Cause
The code generator properly added deprecation warnings but assumed the warnings module would be available without explicitly importing it.
Solution
import warnings
when deprecated features are detectedtest_warnings_import_for_deprecated_message()
) to verify:Testing
Impact
Fixes runtime errors when using deprecated protobuf definitions while maintaining all existing warning behavior.
Checklist