Skip to content

Updating dependencies for angular 13 and adding imports to public_api.ts #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2022

Conversation

jsrosas
Copy link
Contributor

@jsrosas jsrosas commented May 13, 2022

  • Update library and app to Angular13
  • Exporting classes exposed by module but not by entry point.

@davidwalschots
Copy link
Owner

Thank you for your contribution! I am wondering what use case you are running into that requires exporting the ValidationMessageComponent, FormDirective, and ValidationMessagesComponent types?

@jsrosas
Copy link
Contributor Author

jsrosas commented May 13, 2022

During npm run build:lib
× Compiling with Angular sources in Ivy partial compilation mode.
angular-reactive-validation/src/validation-message/validation-message.component.ts:18:14 - error NG3001: Unsupported private class ValidationMessageComponent. This class is visible to consumers via ReactiveValidationModule -> ValidationMessageComponent, but is not exported from the top-level library entrypoint.

18 export class ValidationMessageComponent implements OnInit {
~~~~~~~~~~~~~~~~~~~~~~~~~~~
angular-reactive-validation/src/form/form.directive.ts:12:14 - error NG3001: Unsupported private class FormDirective. This class is visible to consumers via ReactiveValidationModule -> FormDirective, but is not exported from the top-level library entrypoint.

12 export class FormDirective {
~~~~~~~~~~~~~~
angular-reactive-validation/src/validation-messages/validation-messages.component.ts:24:14 - error NG3001: Unsupported private class ValidationMessagesComponent. This class is visible to consumers via ReactiveValidationModule -> ValidationMessagesComponent, but is not exported from the top-level library entrypoint.

24 export class ValidationMessagesComponent implements AfterContentInit, OnDestroy, OnInit {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@davidwalschots
Copy link
Owner

Interesting. It's a shame exposing these is now necessary, as users of this library shouldn't care about those internals, just about using them inside HTML. Angular will be Angular I guess 😀.

@davidwalschots davidwalschots merged commit 09cd03e into davidwalschots:master May 13, 2022
@jsrosas
Copy link
Contributor Author

jsrosas commented May 13, 2022

Yeah indeed.

@jsrosas jsrosas deleted the feat/angular13 branch May 13, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants