Skip to content

Revert "Block: Handle bottom_snap property directly" #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2024
Merged

Revert "Block: Handle bottom_snap property directly" #153

merged 1 commit into from
Jul 22, 2024

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Jul 22, 2024 •
edited
Loading

@manuq manuq requested review from dbnicholson and wnbaum July 22, 2024 18:20
wnbaum
wnbaum approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@wnbaum wnbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think Node exports are buggy in 4.2. I actually think they fixed this in 4.3! godotengine/godot#82670

@wnbaum wnbaum merged commit 5264f9c into main Jul 22, 2024
2 checks passed
@wnbaum wnbaum deleted the T35573-revert-bottom-snap-path branch July 22, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnbaum wnbaum wnbaum approved these changes

@dbnicholson dbnicholson Awaiting requested review from dbnicholson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuq @wnbaum