Add randi, randf, randf_range and randi_range blocks #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuq
reviewed
Aug 13, 2024
| b = BLOCKS["parameter_block"].instantiate() | ||
| b.block_name = "randf_range" | ||
| b.variant_type = TYPE_FLOAT | ||
| b.block_format = "randf_range({from: FLOAT}, {to: FLOAT})" |
There was a problem hiding this comment.
This block_format goes to the UI label so you can be verbose: Get random float from {from: FLOAT} to {to: FLOAT}. And you can also add tooltip text with the explanation in Godot docs:
b.tooltip_text = "Returns a pseudo-random float between [i]from[/i] and [i]to[/i] (inclusive)."
The tooltip text supports rich text with BBCode format.
There was a problem hiding this comment.
Will do, thank you for your suggestion
There was a problem hiding this comment.
Thanks to you for contributing this!
According to the discussion [1], add the sound blocks into function get_built_in_blocks()'s class matching. It generates blocks belonging to AudioStreamPlayer node, including setting the property's value. Therfore, we have sound blocks in both types of general script and GDScript flavor. [1]: endlessm#161 (comment) https://phabricator.endlessm.com/T35609
This reverts commit b7b6fa8.
|
Sorry, about creating a new pull request (#194). I am new to this github workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to use these 4 godot global functions (randi, randf, randf_range and rangi_range) to generate random numbers as requested in #185.