Fix error in simple_spawner.gd with Godot 4.2.2 #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Godot 4.3, it is possible to use is_instance_valid as a Callable. To support Godot 4.2.2, we must use an anonymous function instead.
starnight
reviewed
Oct 2, 2024
| @@ -79,7 +79,7 @@ func spawn_once(): | |||
| if scenes.size() == 0: | |||
| return | |||
|
|
|||
| _spawned_scenes = _spawned_scenes.filter(is_instance_valid) | |||
| _spawned_scenes = _spawned_scenes.filter(func(instance): return is_instance_valid(instance)) | |||
There was a problem hiding this comment.
I try to understand the func() and instance. Then, I found it is Godot 4 lambda functions.
starnight
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Godot 4.3, it is possible to use is_instance_valid as a Callable. To support Godot 4.2.2, we must use an anonymous function instead.