-
Notifications
You must be signed in to change notification settings - Fork 27
Translation infrastructure #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c5b3feb
Add BlockDefinition translation parser plugin
dbnicholson 40d6c23
Add translation utilities
dbnicholson 50b093a
Load translations when initializing plugin
dbnicholson e854330
Set translation domain on top level nodes
dbnicholson 531cbbf
inspector_plugin: Translate button text
dbnicholson 3e208d7
ui: Translate displayed block and category strings
dbnicholson 7d5a53e
variable_dialog: Disable translation of input fields
dbnicholson c2eba97
ParameterInput: Disable translation of input fields
dbnicholson d7f50c4
Avoid translating empty strings
dbnicholson 4ed2a6c
Add tool to regenerate POT file
dbnicholson ab90d9f
Add tool to update POT files
dbnicholson deabb02
Add translated files and update POT file
dbnicholson 0c044ac
locale: Create common message catalogs
dbnicholson 6d149f0
Add localization documentation
dbnicholson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how feasible it would be to have a CI job that runs a (real, not headless) editor and then executes these...
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. The
TxUtils.update_pot_files
one is independent of the editor, so you could write a headlessSceneTree
script that we could run from CI. I almost started doing it but decided to wait for now sinceTxUtils.regenerate_pot_file
is very much dependent on the editor and I had no idea if that could be scripted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One for another day I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured this out (at least one way). It's kinda nasty, but I'll make a PR for it.