Skip to content

Switch property labels back to human readable #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

manuq
Copy link
Contributor

@manuq manuq commented Nov 4, 2024

In commit c18ab3f we regressed the property names from capitalized to lower case. We actually want both: capitalize them and then lower case them.

Fixes #302

In commit c18ab3f we regressed the property names from capitalized to
lower case. We actually want both: capitalize them and then lower case
them.

Fixes #302
Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense after reading that capitalize is more like a conversion to a sentence.

@dbnicholson dbnicholson merged commit 097d046 into main Nov 4, 2024
3 checks passed
@dbnicholson dbnicholson deleted the fix-property-labels branch November 4, 2024 23:54
@manuq
Copy link
Contributor Author

manuq commented Nov 5, 2024

I think that makes sense after reading that capitalize is more like a conversion to a sentence.

Yes, it's not like Python's capitalize which makes the first character upper case and the rest lower-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The label in blocks for propeties has regressed
2 participants