Skip to content

feat(esp_now): Add support for ESP NOW V2 #11524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(esp_now): Add support for ESP NOW V2 #11524

wants to merge 2 commits into from
+98 −15

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Add support for ESP-NOW v2.0 data sizes.

Tests scenarios

Tested locally

Related links

Closes #11261

@lucasssvaz lucasssvaz added this to the 3.2.1 milestone Jun 27, 2025
@lucasssvaz lucasssvaz self-assigned this Jun 27, 2025
@lucasssvaz lucasssvaz requested a review from P-R-O-C-H-Y as a code owner June 27, 2025 11:44
@lucasssvaz lucasssvaz added the Area: ESP-NOW Issues and Feature Request about ESP-NOW Protocol label Jun 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 514836f

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025 •
edited
Loading

Test Results

 76 files   76 suites   13m 10s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit 514836f.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap Jun 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master----------
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave----------
libraries/ESP_NOW/examples/ESP_NOW_Network----------
libraries/ESP_NOW/examples/ESP_NOW_Serial----------

P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Jun 27, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev June 27, 2025 12:23
lucasssvaz
lucasssvaz commented Jun 27, 2025
View reviewed changes
libraries/ESP_NOW/src/ESP32_NOW_Serial.cpp
Comment on lines +78 to +79
buf_size = setRxBufferSize(4096);
buf_size &= setTxBufferSize(4096);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep the 1024 buffer size but print a warning that the buffers might be too small.

@lucasssvaz
Copy link
Collaborator Author

Also I couldn't find any information if the version depends only on the ESP-IDF version. If yes we can just replace everything with the new size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@lucasssvaz lucasssvaz

Labels
Area: ESP-NOW Issues and Feature Request about ESP-NOW Protocol Status: Review needed Issue or PR is awaiting review
Projects
Arduino ESP32 Core Project Roadmap
Status: In Review
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

Support ESP-Now Version 2 packet size
2 participants
@lucasssvaz @P-R-O-C-H-Y