Skip to content

CRA --template not picking up github url from a nested folder. #9211

Open
@adeelibr

Description

@adeelibr

Describe the bug

I am trying to init a create-react-app with a github url

npx create-react-app my-app --use-npm --template git+ssh://git@github.com/<orgname>/<repo>.git/<folder-name>/react-scripts/cra-template-javascript

The issue is my github repo has multiple templates, I can run them locally like

npx create-react-app my-app --use-npm --template file:/Users/adeelimran/Desktop/adeel/repos/sandbox/adeel_imran/react-scripts/cra-template-typescript

But I can run it via the github link, because the project folder is under a nested github folder.

Did you try recovering your dependencies?

This issue does not have dependencies.

Which terms did you search for in User Guide?

https://create-react-app.dev/docs/custom-templates

Environment

Environment Info:

  current version of create-react-app: 3.4.1
  running from /Users/adeelimran/.npm/_npx/45395/lib/node_modules/create-react-app

  System:
    OS: macOS 10.15.5
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 14.4.0 - ~/.nvm/versions/node/v14.4.0/bin/node
    Yarn: 1.22.4 - ~/.yarn/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v14.4.0/bin/npm
  Browsers:
    Chrome: 83.0.4103.106
    Firefox: 64.0.2
    Safari: 13.1.1
  npmPackages:
    react: Not Found
    react-dom: Not Found
    react-scripts: Not Found
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

  1. Create a github repo
  2. Inside that repo create some nested folders
  3. In one of the templates add the content as is from here https://github.com/facebook/create-react-app/tree/master/packages/cra-template
  4. On executing npx create-react-app my-app --use-npm --template git+ssh://git@github.com/<username>/<repo-name>.git/folder1/fodler2/cra-template-javascript
  5. It should find this folder & init a CRA project using the given template

Expected behavior

(Write what you thought would happen.)

It should create the project reading from the github url.

Actual behavior

(Write what happened. Please add screenshots!)

Screenshot 2020-06-24 at 15 28 27

Reproducible demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions